From 7844ec6b5475005ebef5c1767546482838993b7c Mon Sep 17 00:00:00 2001 From: Praveen Kumar Date: Wed, 21 Dec 2016 16:53:35 +0100 Subject: [PATCH] sched: removal of redundant check in Credit The patch gets rid of a redundant check in csched_vcpu_acct. In fact, the function is only called from csched_tick, which already checks that current is not the idle vcpu. The patch also adds an ASSERT to the same effect, in order to make assumption ( i.e., no calling this on idle vcpus) even more clear and as a guard for future mis-use. Signed-off-by: Praveen Kumar Acked-by: Dario Faggioli --- xen/common/sched_credit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c index fc3a32127c..dfe8545800 100644 --- a/xen/common/sched_credit.c +++ b/xen/common/sched_credit.c @@ -941,6 +941,7 @@ csched_vcpu_acct(struct csched_private *prv, unsigned int cpu) ASSERT( current->processor == cpu ); ASSERT( svc->sdom != NULL ); + ASSERT( !is_idle_vcpu(svc->vcpu) ); /* * If this VCPU's priority was boosted when it last awoke, reset it. @@ -957,8 +958,7 @@ csched_vcpu_acct(struct csched_private *prv, unsigned int cpu) /* * Update credits */ - if ( !is_idle_vcpu(svc->vcpu) ) - burn_credits(svc, NOW()); + burn_credits(svc, NOW()); /* * Put this VCPU and domain back on the active list if it was -- 2.30.2